Skip to content

DataSampling: make sure the original DataHeader is available in the sampled data#14164

Merged
ktf merged 2 commits intoAliceO2Group:devfrom
ktf:pr14164
Apr 10, 2025
Merged

DataSampling: make sure the original DataHeader is available in the sampled data#14164
ktf merged 2 commits intoAliceO2Group:devfrom
ktf:pr14164

Conversation

@ktf
Copy link
Member

@ktf ktf commented Apr 10, 2025 •
edited
Loading

@ktf ktf requested review from a team, Barthelemy, justonedev1 and knopers8 as code owners April 10, 2025 08:23
@ktf ktf mentioned this pull request Apr 10, 2025
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alibuild alibuild mentioned this pull request Apr 10, 2025
Closed
@ktf
Copy link
Member Author

ktf commented Apr 10, 2025

@shahor02 this is what we discussed. The only remaining bit should be to use:

InputRecordWalker<DataSamplingHeader>

where you (possibly) iterated over the sampled data. Notice that it will always use the o2::header::DataHeader as a fallback solution.

Finally if you do not specify any template argument to InputRecordWalker, the previous behaviour is maintained.

@knopers8 @Barthelemy this will copy the original headers into the DataSamplingHeader unconditionally. Let me know if this needs further discussion.

knopers8
knopers8 approved these changes Apr 10, 2025
View reviewed changes
Copy link
Collaborator

@knopers8 knopers8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@ktf
Copy link
Member Author

ktf commented Apr 10, 2025

This works for @shahor02 usecase. I will merge once the tests pass.

@shahor02 shahor02 mentioned this pull request Apr 10, 2025
Merged
@alibuild
Copy link
Collaborator

alibuild commented Apr 10, 2025

Error while checking build/O2/fullCI_slc9 for 2ac46e8 at 2025-04-10 15:28:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile sim.log


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
grep: error-log.txt: binary file matches
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/8f5faabd96f6c5d407d99a3c536f48ca13e11cef/slc9_x86-64/o2checkcode/1.0-local121/etc/modulefiles
++ cat
--

Full log here.

@ktf ktf merged commit 8688938 into AliceO2Group:dev Apr 10, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knopers8 knopers8 knopers8 approved these changes

@Barthelemy Barthelemy Awaiting requested review from Barthelemy Barthelemy is a code owner

@justonedev1 justonedev1 Awaiting requested review from justonedev1 justonedev1 is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ktf @alibuild @knopers8